Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain how to use "tsc waiting" label #18466

Merged
merged 1 commit into from
May 17, 2024
Merged

docs: explain how to use "tsc waiting" label #18466

merged 1 commit into from
May 17, 2024

Conversation

fasttime
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added a section to the "Manage Issues and Pull Requests" page explaining how to request feedback from the TSC, including usage of the "tsc waiting" label as agreed in the 2024-05-16 TSC meeting.

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label May 17, 2024
Copy link

netlify bot commented May 17, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 6c9f931
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6647433d3e64900008ad925a
😎 Deploy Preview https://deploy-preview-18466--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fasttime fasttime marked this pull request as ready for review May 17, 2024 11:52
@fasttime fasttime requested a review from a team as a code owner May 17, 2024 11:52
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label May 17, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like @nzakas to verify before merging.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@nzakas nzakas merged commit ceada8c into main May 17, 2024
20 checks passed
@nzakas nzakas deleted the docs-tsc-waiting branch May 17, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

3 participants