-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide no-empty
option that allows empty catch
blocks.
#2187
Comments
We aren't going to restore the previous behavior. You can still allow empty Happy to discuss other augmentations of the rule that might help you out. |
So |
Yes.
With #2193 that comment will work. |
Thanks, #2193 makes this much easier for me. However, I'd still like an option that does ignore empty |
@ljharb I generally understand your point with a breaking change and in the original #1841 discussion I actually opted for a separate (no-empty-catch) rule altogether. @nzakas convinced me, that keeping this a single rule makes more sense and I still think he was right. I would keep the behavior as it is now and am fine with relaxing the the need for a specific comment to any comment. |
@ljharb thanks for your input. We've already made the other change you requested, so I'm considering the matter closed. I know you disagree with the decision, however, I've already explained the rationale. We have a lot of other issues to focus on now. |
I want to disallow empty blocks in general with the
no-empty
rule, but I do not want to disallow empty "catch" blocks.I'd like an option that restores the pre-
0.18.0
behavior of ignoring emptycatch
blocks.Filing per discussion on #1841 (comment)
The text was updated successfully, but these errors were encountered: