Update: Add option to ignore constructor functions in object-shorthand rule (fixes #4487) #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaicataldo
force-pushed
the
objectshorthandignoreconstructors
branch
8 times, most recently
from
078ace6
to
7fbb3b4
Compare
|
Just wanted to check in on this. |
| "type": "array", | ||
| "items": [ | ||
| { | ||
| "enum": [0, 1, 2] |
There was a problem hiding this comment.
This can now be modified. A change was merged in could of days ago, that doesn't require first parameter in the array to be specified in the schema. Change was made as part of this pull request: #4596
There was a problem hiding this comment.
Awesome - will take a look and fix it. Thanks!
|
Other then schema, LGTM |
kaicataldo
force-pushed
the
objectshorthandignoreconstructors
branch
from
7fbb3b4
to
8c37703
Compare
|
Updated :) |
| "type": "array", | ||
| "items": [ | ||
| { | ||
| "enum": ["always", "methods", "properties", "never"] |
There was a problem hiding this comment.
Should this only have "always" and "methods"? (Based on what the documentation says)
kaicataldo
force-pushed
the
objectshorthandignoreconstructors
branch
from
8c37703
to
44d2276
Compare
|
Looks good, thanks! |
nzakas
added a commit
that referenced
this pull request
Dec 8, 2015
…ctors Update: Add option to ignore constructor functions in object-shorthand rule (fixes #4487)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% confident about the JSON Schema (first time working with it, so please bear with me) - let me know if anything needs to be changed!