New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added example for issue #5498 #6242
Conversation
Thanks for the pull request, @tiemevanveen! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Updated and force-pushed my branch but Github isn't showing any change yet.. |
Thanks for the pull request, @tiemevanveen! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
This does not fix the already closed issue and does not touches code so I assume I don't have to prefix with |
@tiemevanveen thesis for the pull request. Can you sign the CLA? http://contribute.jquery.org/CLA/ the commit message should be in the format "Docs: added examples for arrow-body-style (refs #5498)" |
LGTM |
Hi @nzakas I signed the CLA but somehow it just turned red again after being green for a while.. Also changed the commit message. |
CLA is fine now. Travis build didn't run for some reason, but since it's just a doc change, we can ignore Travis. LGTM |
I think a lot of the automation was borked due to GitHub issues today. |
I think the 19 ❤️ s here indicate that this rule could use an extra example or 2.