Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example for issue #5498 #6242

Merged
merged 1 commit into from May 23, 2016
Merged

Added example for issue #5498 #6242

merged 1 commit into from May 23, 2016

Conversation

teameh
Copy link
Contributor

@teameh teameh commented May 23, 2016

I think the 19 ❤️ s here indicate that this rule could use an extra example or 2.

@eslintbot
Copy link

Thanks for the pull request, @tiemevanveen! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@teameh
Copy link
Contributor Author

teameh commented May 23, 2016

Updated and force-pushed my branch but Github isn't showing any change yet..

@eslintbot
Copy link

Thanks for the pull request, @tiemevanveen! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@teameh
Copy link
Contributor Author

teameh commented May 23, 2016

This does not fix the already closed issue and does not touches code so I assume I don't have to prefix with fixes #5498 right? Any humans around here as well?

@nzakas
Copy link
Member

nzakas commented May 23, 2016

@tiemevanveen thesis for the pull request. Can you sign the CLA? http://contribute.jquery.org/CLA/

the commit message should be in the format "Docs: added examples for arrow-body-style (refs #5498)"

@eslintbot
Copy link

LGTM

@teameh
Copy link
Contributor Author

teameh commented May 23, 2016

Hi @nzakas I signed the CLA but somehow it just turned red again after being green for a while.. Also changed the commit message.

@ilyavolodin
Copy link
Member

CLA is fine now. Travis build didn't run for some reason, but since it's just a doc change, we can ignore Travis. LGTM

@nzakas
Copy link
Member

nzakas commented May 23, 2016

I think a lot of the automation was borked due to GitHub issues today.

@nzakas nzakas merged commit cdd65d7 into eslint:master May 23, 2016
@teameh teameh deleted the patch-1 branch May 23, 2016 19:25
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants