Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better messaging about ^ #6814

Closed
hzoo opened this issue Aug 1, 2016 · 9 comments
Closed

Better messaging about ^ #6814

hzoo opened this issue Aug 1, 2016 · 9 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion needs bikeshedding Minor details about this change need to be discussed

Comments

@hzoo
Copy link
Member

hzoo commented Aug 1, 2016

Ref #6795
Ref #6804

Also I was just thinking that npm install eslint which also automatically uses ^. Just brainstorming, but I think we can maybe add a warning somehow (maybe after install) about using ~ instead of ^?

Most users will still be surprised since they won't see the README/semver policy (mostly for our sake since we'll probably get a lot of reports unless users know about it)

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Aug 1, 2016
@platinumazure platinumazure added enhancement This change enhances an existing feature of ESLint core Relates to ESLint's core APIs and features needs bikeshedding Minor details about this change need to be discussed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Aug 1, 2016
@nzakas
Copy link
Member

nzakas commented Aug 3, 2016

I don't know -- I feel like that's ESlint being a bit too opinionated. Maybe people won't read the docs, but we can always point them to it. I'm not sure we need more than that.

@hzoo
Copy link
Member Author

hzoo commented Aug 4, 2016

Yeah hard to say. Was just exploring what we can do to inform since I think we'll get reports about it whenever there is something like that - given its the default.

It's not in the best spot (or on the website) so even skimming through it you might not see it (or even the semver policy really).

@nzakas
Copy link
Member

nzakas commented Aug 10, 2016

I'm definitely 👎 on having ESLint check what your package.json says when it's running -- some may still want to use ^ and I don't want to nag them about it.

Do you have another recommendation?

@ljharb
Copy link
Sponsor Contributor

ljharb commented Aug 10, 2016

Is it entirely out of the question to change the semver policy in such a way as more things cause semver-major bumps? There's zero things wrong with being on v123.4.5 if it comes to that.

@nzakas
Copy link
Member

nzakas commented Aug 10, 2016

@ljharb we just formalized the policy, so I don't think it's worthwhile to investigate changing it again. We already had a bunch of discussion around it and there's no new information that I could see leading to a different result.

@ljharb
Copy link
Sponsor Contributor

ljharb commented Aug 10, 2016

Gotcha, just wanted to throw that one out there.

@alberto
Copy link
Member

alberto commented Aug 26, 2016

@ljharb actually there is an issue with plugins compatibility.

@ljharb
Copy link
Sponsor Contributor

ljharb commented Aug 26, 2016

@alberto sure, the issue is that plugins would have to release more aggressively.

@nzakas
Copy link
Member

nzakas commented Aug 29, 2016

Unfortunately, it looks like consensus couldn't be reached on this issue and so I'm closing it. While we wish we'd be able to accommodate everyone's requests, we do need to prioritize. We've found that issues failing to reach consensus after 21 days tend never to reach consensus, and as such, we close those issues. This doesn't mean the idea isn't interesting, just that it's not something the team can commit to.

@nzakas nzakas closed this as completed Aug 29, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion needs bikeshedding Minor details about this change need to be discussed
Projects
None yet
Development

No branches or pull requests

6 participants