-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error message not output when loading a plugin #6976
Comments
I'm not sure about output error message to all users, we specifically added pretty messages, because people couldn't figure out what caused an issue. But I do agree that we should output error message as part of the |
@ilyavolodin Well what if it was simply a different pretty message if the error wasn't that the plugin couldn't be found. The whole issue here is that I couldn't figure out the issue because I was told the plugin couldn't be found when it actually couldn't be loaded which are two very different things. |
@corbinu We could probably do a different message, but I think this is meaningful only to plugin creators (very small subset of our users). I'm definitely in favor of adding it to debug log. Separate message is fine by me, as well, but I'm not 100% sure it's necessary. |
👍 I think having the original exception type and string couldn't hurt, in the message or definitely in the debug logs. The fact that the full exception info isn't in the debug logs is a travesty 😢 |
I believe this is covered by #6874 |
This was fixed by #8323. |
What version of ESLint are you using?
3.3.1
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
I tried creating a plugin with my own config. I had an error in my plugin. However this simply displayed "ESLint couldn't find the plugin" couldn't find the plugin rather than the correct error message
What did you expect to happen?
I expected plugin-missing.txt to output the error message thrown by node.
What actually happened? Please include the actual, raw output from ESLint.
I think the template should just be modified to include the err.message from the require try incase the issue is not the plugin not being found but instead the plugin being broken. Or this should at least be output when --debug is run
The text was updated successfully, but these errors were encountered: