Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update release process #7127

Merged
merged 1 commit into from Sep 13, 2016
Merged

Docs: Update release process #7127

merged 1 commit into from Sep 13, 2016

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Sep 12, 2016

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

If the item you've check above has a template, please paste the template questions here and answer them.

Please check each item to ensure your pull request is ready:

  • I've read the pull request guide
  • I've included tests for my change
  • I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

Updated the maintainer guide release docs to better spell out the release process.

Is there anything you'd like reviewers to focus on?

Is the information clear?

@eslintbot
Copy link

LGTM

2. Log into Jenkins and schedule a build for the "ESLint Release" job.
3. Wait for the "ESLint Release" job to complete.
4. Update the release blog post with a "Highlights", including new rules and anything else that's important.
4. Make release announcement in the chatroom.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two #4 items.

@platinumazure
Copy link
Member

I think you'll have markdownlint problems because some sub-bullets are only indented 2 spaces (we have it configured for 4-space sub-list indents).

@nzakas
Copy link
Member Author

nzakas commented Sep 12, 2016

Ah crap, right. I'll fix that.

@eslintbot
Copy link

LGTM

@platinumazure
Copy link
Member

LGTM, thanks for updating this!

@btmills
Copy link
Member

btmills commented Sep 12, 2016

LGTM

1 similar comment
@kaicataldo
Copy link
Member

LGTM

@gyandeeps
Copy link
Member

LGTM 👍

@ilyavolodin ilyavolodin merged commit 7e8316f into master Sep 13, 2016
@alberto alberto deleted the releasedocs branch December 15, 2016 22:05
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants