Fix: Don't report async/generator callbacks in array-callback-return

[not-an-aardvark]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Please check each item to ensure your pull request is ready:

• I've read the pull request guide
• I've included tests for my change
• I've updated documentation for my change (if appropriate)

What changes did you make? (Give an overview)

See #7101 for context. This is one of the rule fixes that prevents incorrect behavior now that we can support async functions.

This fix updates array-callback-return to not report async callback functions, since async functions implicitly return a Promise value.

/* eslint array-callback-return: 2 */
foo.map(async function () {}) // should not return an error
foo.map(async () => {}) // should not return an error

Is there anything you'd like reviewers to focus on?

Nothing in particular.

[mention-bot]

@not-an-aardvark, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vitorbal, @mysticatea and @kaicataldo to be potential reviewers

[eslintbot]

LGTM

[mysticatea]

Thank you!

I was hovering between a bug and an enhancement.
But indeed, async functions and generators have implicit returned values. I think this is like a bug.

@not-an-aardvark in addition, could you add the check for generators as same?

[eslintbot]

LGTM

[not-an-aardvark]

Added a check for generator functions.

[not-an-aardvark]

I'm going to rebase all my PRs onto master so that the tests pass (sorry about the spammy "LGTM" messages).

[eslintbot]

LGTM

[mysticatea]

LGTM, thank you!

[platinumazure]

LGTM, thanks!