Fix: no-unused-vars
false positive (fixes #7250)
#7258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
See #7250 for template.
Please check each item to ensure your pull request is ready:
I've updated documentation for my change (if appropriate)What changes did you make? (Give an overview)
I had changed the
after-used
option's behavior in #7143 in order to fix the false negative that the rule overlooks unused variables if the last parameter is ignored byargsIgnorePattern
.Now, the rule has false positive that it warns the last non-ignored parameter even if the last (ignored) parameter is used.
This PR fixes the false positive.
semver-patch
: A bug fix in a rule that results in ESLint reporting fewer errors.Is there anything you'd like reviewers to focus on?