Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Rules restricting globals/properties/syntax are linked together #7743

Merged
merged 1 commit into from Dec 12, 2016

Conversation

platinumazure
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update

What changes did you make? (Give an overview)

Ensured that no-restricted-globals, no-restricted-properties, and no-restricted-syntax all linked to each other in their documentation.

Is there anything you'd like reviewers to focus on?

I'm not sure no-restricted-syntax really fits with no-restricted-globals and no-restricted-properties, but there was already a link between no-restricted-properties and no-restricted-syntax. Should I instead remove no-restricted-syntax from the other two rules? no-restricted-syntax points to rules like no-debugger which it supersedes.

Rules `no-restricted-globals`, `no-restricted-properties`, and `no-restricted-syntax` link to each other in their Related Rules sections.
@mention-bot
Copy link

@platinumazure, thanks for your PR! By analyzing the history of the files in this pull request, we identified @TheSavior, @not-an-aardvark and @BenoitZugmeyer to be potential reviewers.

@eslintbot
Copy link

LGTM

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I instead remove no-restricted-syntax from the other two rules?
I think this is fine, personally.

@kaicataldo
Copy link
Member

Whoops, formatting got wonky. Above comment should be:

Should I instead remove no-restricted-syntax from the other two rules?

I think this is fine, personally.

@platinumazure
Copy link
Member Author

Thanks @gyandeeps and @kaicataldo. I'm going to merge this. If something needs to change, I can do so in a separate PR.

@platinumazure platinumazure merged commit ab246dd into master Dec 12, 2016
@platinumazure platinumazure deleted the no-restricted-docs branch December 12, 2016 19:47
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants