Docs: Adding an example for the spread operator to prefer-spread.md (#7802)

[butlermd]

What is the purpose of this pull request? (put an "X" next to item)

[ X ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Adding an example of using the spread operator per #7802.

Do I need to squash the commits?

[mention-bot]

@butlermd, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @aubergine10 and @gcochard to be potential reviewers.

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ butlermd
❌ Michael D Butler

---

Michael D Butler seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

[eslintbot]

Thanks for the pull request, @butlermd! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[vitorbal]

Thanks! No need to squash the commits, we can take care of that when we merge.

[butlermd]

Sounds good.

[vitorbal]

Minor nit: could you get rid of this empty line, as none of the other examples below have one?

[butlermd]

Yes, that makes sense. While I'm looking at it, the incorrect examples have an empty line between them while the correct examples don't. Should I also remove those empty lines (33 and 35)?

[eslintbot]

Thanks for the pull request, @butlermd! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[platinumazure]

@butlermd Could you please sign our Contributor License Agreement? We can't accept pull requests unless the committer(s) sign the CLA. Thanks!

[butlermd]

I did and when I try to sign it again it says I've already signed. Some issue with the integration?

[platinumazure]

@butlermd Does the CLA signature match your Git name and e-mail address? Some or all of those have to match, otherwise your signature won't be associated with the commits.

Come by our chat room if you need help looking into that.

[not-an-aardvark]

It looks like the git commit author/email of your most recent commit ("removed excess whitespace per vitorbal's comment") is different from the author/email of the other commits. The bot requires that all the commit authors must have signed the CLA.

Assuming the last commit was also created by you, you could amend it to use the same author/email as before.

[butlermd]

Thanks @not-an-aardvark and @platinumazure. Got it figured out. Committed with a key that's associated with my work email. Added the email to my github profile. I think I'll need to make another commit to get the integration to recognize it. Should I make the change to the spacing of the incorrect examples to make it consistent with the correct examples?

[platinumazure]

@butlermd Note that adding another commit won't fix the CLA issue by itself, because you'll still have the old commit with the wrong name/e-mail. You need to amend that previous commit and force-push. Stop by in our chat if you need help with that.

[eslintbot]

Thanks for the pull request, @butlermd! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[vitorbal]

@butlermd sure, makes sense to make sure they're all consistent!

…

On Wed, Dec 21, 2016 at 7:10 PM ESLint Bot ***@***.***> wrote: Thanks for the pull request, @butlermd <https://github.com/butlermd>! I took a look to make sure it's ready for merging and found some changes are needed: - The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide <http://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes> for how to properly format your commit summary and update <http://eslint.org/docs/developer-guide/contributing/pull-requests#updating-the-commit-message> it on this pull request. Can you please update the pull request to address these? (More information can be found in our pull request guide <http://eslint.org/docs/developer-guide/contributing/pull-requests>.) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#7804 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAmNdpsxaygY3mYdDI5rw_hQ017lz72eks5rKWuEgaJpZM4LTB4V> .

[butlermd]

I amended the commit and force pushed. It appears to have fixed the license issue.

[eslintbot]

Thanks for the pull request, @butlermd! I took a look to make sure it's ready for merging and found some changes are needed:

• The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

[not-an-aardvark]

LGTM. Thanks!

[vitorbal]

Thanks for the contribution, @butlermd!

[butlermd]

Glad to help!