Docs: update outdated info in Architecture page #7816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `cli` description stated that `bin/eslint.js` calls `process.exit()`, but this is no longer correct (this changed in 759525e). * The `eslint` description stated that the traverser emits events with the `:after` suffix when exiting nodes, but it actually emits events with the `:exit` suffix (this changed in f1f453d).
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas and @alberto to be potential reviewers. |
|
LGTM |
vitorbal
approved these changes
Dec 26, 2016
platinumazure
approved these changes
Dec 26, 2016
|
Nice! |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Documentation update
What changes did you make? (Give an overview)
clidescription stated thatbin/eslint.jscallsprocess.exit(), but this is no longer correct (this changed in 759525e).eslintdescription stated that the traverser emits events with the:aftersuffix when exiting nodes, but it actually emits events with the:exitsuffix (this changed in f1f453d).Is there anything you'd like reviewers to focus on?
Nothing in particular