Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category for ES7 Rules #8003

Closed
danny-andrews opened this issue Jan 31, 2017 · 3 comments
Closed

Category for ES7 Rules #8003

danny-andrews opened this issue Jan 31, 2017 · 3 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion

Comments

@danny-andrews
Copy link
Contributor

I noticed we have three rules relating to the es7 await function feature: 'no-await-in-loop', 'no-return-await', and 'require-await', but we don't have an es7 rule category like we do for es6. Is this something we would like to move forward on?

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Jan 31, 2017
@danny-andrews danny-andrews changed the title Category for ES7 Category for ES7 Rules Jan 31, 2017
@platinumazure
Copy link
Member

We have a discussion here about doing the opposite for ES6.

In my view (as I've made clear in the other issue), the best approach is to have only three categories based on severity of the error: Possible Errors, Best Practices, and Stylistic Issues; and then anything else (ES6, Variables, Strict Mode, and now possibly ES7) would be tags that could be filtered on, and a rule could have zero or more tags. (But this is just my view, and the team has not come to a consensus on how to handle this.)

@vitorbal
Copy link
Member

vitorbal commented Feb 1, 2017

@platinumazure I'm +1 for your proposal as well. @danny-andrews do you mind if we move this discussion to #7991 to keep things more focused?

@vitorbal vitorbal added documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Feb 1, 2017
@danny-andrews
Copy link
Contributor Author

Not at all, I figured this was a discussion somewhere else, I just couldn't find the ticket. Thanks!

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation enhancement This change enhances an existing feature of ESLint evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion
Projects
None yet
Development

No branches or pull requests

4 participants