Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Small typos #8121

Merged
merged 1 commit into from Feb 21, 2017
Merged

Fix: Small typos #8121

merged 1 commit into from Feb 21, 2017

Conversation

glennreyes
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added missing quotes to the key-spacing option list

Is there anything you'd like reviewers to focus on?

@mention-bot
Copy link

@glennreyes, thanks for your PR! By analyzing the history of the files in this pull request, we identified @scriptdaemon, @IanVS and @btmills to be potential reviewers.

@jsf-clabot
Copy link

jsf-clabot commented Feb 21, 2017

CLA assistant check
All committers have signed the CLA.

@eslintbot
Copy link

Thanks for the pull request, @glennreyes! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

Copy link
Member

@gyandeeps gyandeeps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update commit message during merge

@glennreyes glennreyes changed the title Docs: Small typos Fix: Small typos Feb 21, 2017
@glennreyes
Copy link
Contributor Author

Updated @gyandeeps

@gyandeeps
Copy link
Member

LGTM 👍
Thanks for contributing.

@gyandeeps gyandeeps merged commit 9fa2559 into eslint:master Feb 21, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants