Update: deprecate applyDefaultPatterns
in line-comment-position
#8183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What rule do you want to change?
line-comment-position
Does this change cause the rule to produce more or fewer warnings?
The same.
How will the change be implemented? (New option, new default behavior, etc.)?
New option name
applyDefaultIgnorePatterns
replacing old oneapplyDefaultPatterns
.Please provide some example code that this change will affect:
What does the rule currently do for this code?
Complains about comment not being beside code.
What will the rule do after it's changed?
Same behaviour, under the new option name, if used.
What changes did you make? (Give an overview)
Following the discussion in #8155 I have rename the option name so it's clearer and consistent with
lines-around-comments
.Is there anything you'd like reviewers to focus on?
Old option is still present and functional, so it's not a breaking change.