Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: deprecate applyDefaultPatterns in line-comment-position #8183

Merged
merged 1 commit into from Mar 3, 2017

Conversation

alberto
Copy link
Member

@alberto alberto commented Mar 2, 2017

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[X] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What rule do you want to change?
line-comment-position

Does this change cause the rule to produce more or fewer warnings?
The same.

How will the change be implemented? (New option, new default behavior, etc.)?
New option name applyDefaultIgnorePatterns replacing old one applyDefaultPatterns.

Please provide some example code that this change will affect:

/*eslint line-comment-position: ["error", { "position": "beside", "applyDefaultPatterns": false }]*/
// jscs-disable
1 + 1;

What does the rule currently do for this code?
Complains about comment not being beside code.

What will the rule do after it's changed?
Same behaviour, under the new option name, if used.

What changes did you make? (Give an overview)
Following the discussion in #8155 I have rename the option name so it's clearer and consistent with lines-around-comments.

Is there anything you'd like reviewers to focus on?
Old option is still present and functional, so it's not a breaking change.

@mention-bot
Copy link

@alberto, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @amercier and @platinumazure to be potential reviewers.

@eslintbot
Copy link

LGTM

@alberto alberto added accepted There is consensus among the team that this change meets the criteria for inclusion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules labels Mar 3, 2017
@not-an-aardvark not-an-aardvark merged commit 4fdf6d7 into master Mar 3, 2017
@ilyavolodin ilyavolodin deleted the rename-ignore-prop branch March 3, 2017 22:14
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants