Fix: no-multi-spaces false positive with irregular indent whitespace #8412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix
Tell us about your environment
What parser (default, Babel-ESLint, etc.) are you using?
default
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
What did you expect to happen?
I expected no error to be reported because the whitespace is at the beginning of the line.
What actually happened? Please include the actual, raw output from ESLint.
The code was autofixed to invalid syntax:
What changes did you make? (Give an overview)
The no-multi-spaces rule is not intended to check whitespace at the beginning of a line, because consecutive spaces are often used for indentation. Due to a bug, the rule previously matched against consecutive spaces that appeared after an irreglar whitespace character at the beginning of a line. The rule's autofixer assumes that the detected spaces are always between two tokens on the same line, so it would sometimes produce invalid syntax if the rule matched whitespace at the beginning of a line. This commit updates the rule to avoid matching whitespace at the beginning of a line.
Is there anything you'd like reviewers to focus on?
Nothing in particular