Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint does not handle folders started from dot (e.g. /.tests). #8429

Closed
strctr opened this issue Apr 8, 2017 · 5 comments
Closed

ESLint does not handle folders started from dot (e.g. /.tests). #8429

strctr opened this issue Apr 8, 2017 · 5 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion needs info Not enough information has been provided to triage this issue triage An ESLint team member will look at this issue soon

Comments

@strctr
Copy link

strctr commented Apr 8, 2017

I store my tests in .tests folders. When I want to lint my project eslint ignore them, but it sees them If I specify it directly.

screenshot 2017-04-08 16 41 16

System: macOS.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Apr 8, 2017
@eslintbot
Copy link

eslintbot commented Apr 9, 2017

Hi @anton-kabysh, thanks for the issue. It looks like there's not enough information for us to know how to help you.

If you're reporting a bug, please be sure to include:

  1. The version of ESLint you are using (run eslint -v)
  2. What you did (the source code and ESLint configuration)
  3. The actual ESLint output complete with numbers
  4. What you expected to happen instead

(edited by platinumazure)

@not-an-aardvark not-an-aardvark added the needs info Not enough information has been provided to triage this issue label Apr 9, 2017
@ilyavolodin
Copy link
Member

@IanVS correct me if I'm wrong, but we added a fix a little while back to ignore hidden folders by default, right?
@anton-kabysh You need to unignore hidden folders in .eslintignore file in order for them to be linted.

@strctr
Copy link
Author

strctr commented Apr 9, 2017

  1. v3.19.0
  2. My custom config based on airbnb config.
  3. ESLint does not lint directory /.test
  4. Expect to lint code in this dir.

@ilyavolodin I just add !/app/** to .eslintignore and this helps. Thanks!
I'll close the issue. Best.

@strctr strctr closed this as completed Apr 9, 2017
@IanVS
Copy link
Member

IanVS commented Apr 10, 2017

but we added a fix a little while back to ignore hidden folders by default, right?

@ilyavolodin, we've always ignored hidden files and folders by default, but recently we made a fix so that ESLint does not even get passed the files in hidden folders, which makes it run bit faster.

@bbugh
Copy link

bbugh commented Jan 8, 2018

If anyone else gets here via Google trying to figure out why dot folders are ignored, you can fix it by adding a negating ignore in your .eslintignore:

!/.storybook

Now anything like .storybook/config.js will be included in the lint.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion needs info Not enough information has been provided to triage this issue triage An ESLint team member will look at this issue soon
Projects
None yet
Development

No branches or pull requests

6 participants