Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor rephrasing in documentation: about page #8600

Closed
sudarsangp opened this issue May 15, 2017 · 4 comments · Fixed by #8609
Closed

minor rephrasing in documentation: about page #8600

sudarsangp opened this issue May 15, 2017 · 4 comments · Fixed by #8609
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation website Relates to ESLint's website at eslint.github.io

Comments

@sudarsangp
Copy link
Contributor

Under Philosophy section, Every rule subsection

existing: Can be able to be turned off or on
suggestion: Can be turned off or on

existing: Can be set to be a warning or error individually
suggestion: Can be set to a warning or error individually
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label May 15, 2017
@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation website Relates to ESLint's website at eslint.github.io and removed triage An ESLint team member will look at this issue soon labels May 15, 2017
@platinumazure
Copy link
Member

Hi @sudarsangp, thanks for the issue. I agree with those changes (especially the first one).

Would you be interested in opening a pull request against eslint.github.io to fix these?

@sudarsangp
Copy link
Contributor Author

Hi @platinumazure, yes for sure!

Please refer to the PR here (eslint/archive-website#352)

@ilyavolodin
Copy link
Member

@platinumazure This change needs to be done in ESLint main repository, as about file is copied from here as part of the release process.

@platinumazure
Copy link
Member

@ilyavolodin Why is that file, which shouldn't depend on rule metadata, generated from here?

@sudarsangp sudarsangp mentioned this issue May 16, 2017
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation website Relates to ESLint's website at eslint.github.io
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docs: Rephrase in about section sudarsangp/eslint
4 participants
@platinumazure @ilyavolodin @sudarsangp @eslintbot