Chore: make shelljs a devDependency instead of a dependency #8608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soda0289
reviewed
May 16, 2017
| @@ -53,7 +53,7 @@ function installSyncSaveDev(packages) { | |||
| if (Array.isArray(packages)) { | |||
| packages = packages.join(" "); | |||
| } | |||
| shell.exec(`npm i --save-dev ${packages}`, { stdio: "inherit" }); | |||
| childProcess.execSync(`npm i --save-dev ${packages}`, { stdio: "inherit", encoding: "utf8" }); | |||
There was a problem hiding this comment.
Have you tested this on windows? Edit: I see you mentioned this the PR, sorry.
I always have trouble using childProcess.exec() on windows with node packages or batch file.
There was a problem hiding this comment.
I tested it in Windows (cmd/ps) and Windows 10 Bash both work as expected.
It is childProccess.spawn() that has problems with running batch files but childProcess.exe() runs in a command prompt or shell that allows it to run normally.
mysticatea
approved these changes
May 16, 2017
The shelljs module is quite large, and we only use it for a few simple operations that can easily be replaced with standard library functions. This commit makes shelljs a devDevDependency instead.
not-an-aardvark
force-pushed
the
remove-shelljs-dependency
branch
from
b7db75d
to
9ec414f
Compare
|
LGTM |
|
Edit: We've had a few folks test in Windows already, feel free to merge. |
soda0289
approved these changes
May 16, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
The shelljs module is quite large, and we only use it for a few simple operations that can easily be replaced with standard library functions. This commit makes shelljs a devDependency instead.
Is there anything you'd like reviewers to focus on?
Our tests for
npm-utilare not very thorough -- they use method stubs and don't verify whether a command was actually executed successfully. We should probably make them sturdier in the future.Can someone that uses Windows double-check that the
npm installcommand works when usingeslint --initand selecting a popular styleguide? I've tested it on macOS, but I want to make sure it works on Windows as well, since I know there are somechild_processquirks between platforms.