Chore: remove dead code from prefer-const #8683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was added to work around a bug in acorn (acornjs/acorn#487), which has since been fixed.
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @NickHeiner and @vitorbal to be potential reviewers. |
|
LGTM |
There was a problem hiding this comment.
This change LGTM, but I want to make sure our dependency specifiers will definitely prevent this from recurring for our users.
- Does latest espree specify a version range for acorn where this is definitely fixed in all specified versions?
- Does the minimum version of espree allowed by ESLint's specified version range point to a version of espree that consumes acorn versions which definitely have this fixed?
If the answer to either of those questions is no or unsure, then I think we should potentially do one or both of the below:
- Upgrade the Acorn version specification in espree and cut a patch release
- Upgrade the espree version specification in ESLint as part of this PR
If you believe that the minimum supported espree points to a minimum supported acorn which has the Acorn bug fixed, ping me and I'll switch to approve.
gyandeeps
approved these changes
Jun 3, 2017
|
@platinumazure We depend on |
This was referenced Jun 23, 2017
This was referenced Jul 7, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This code was added to work around a bug in acorn (acornjs/acorn#487), which has since been fixed.
Is there anything you'd like reviewers to focus on?
Nothing in particular