Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Semi-Style only check for comments when tokens exist (fixes #8696) #8697

Merged
merged 1 commit into from Jun 9, 2017

Conversation

soda0289
Copy link
Member

@soda0289 soda0289 commented Jun 7, 2017

What is the purpose of this pull request? (put an "X" next to item)
[ X ] Bug fix (template)

What changes did you make? (Give an overview)
Ensure prevToken and nextToken are not null before checking for comments

Is there anything you'd like reviewers to focus on?
Nothing

@eslintbot
Copy link

LGTM

@soda0289 soda0289 added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Jun 7, 2017
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@soda0289
Copy link
Member Author

soda0289 commented Jun 8, 2017

Fixing CLA

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants