Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update object-shorthand.md to fix typo. #9066

Merged
merged 1 commit into from Aug 5, 2017
Merged

Conversation

B3rry
Copy link
Contributor

@B3rry B3rry commented Aug 3, 2017

What is the purpose of this pull request? (put an "X" next to item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
Added a closing quotation mark to the option definition on line 92.

Is there anything you'd like reviewers to focus on?
No.

@jsf-clabot
Copy link

jsf-clabot commented Aug 3, 2017

CLA assistant check
All committers have signed the CLA.

@mention-bot
Copy link

@B3rry, thanks for your PR! By analyzing the history of the files in this pull request, we identified @IanVS, @scriptdaemon and @kaicataldo to be potential reviewers.

@eslintbot
Copy link

Thanks for the pull request, @B3rry! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@B3rry B3rry changed the title Update object-shorthand.md to fix typo. Fix: Update object-shorthand.md to fix typo. Aug 3, 2017
@gyandeeps
Copy link
Member

Is your eslint fork super old or something?

@B3rry
Copy link
Contributor Author

B3rry commented Aug 3, 2017

With regards to the failing builds? Nope. Forked ~30 mins ago via the site.

@not-an-aardvark
Copy link
Member

It looks like your commit was created off of the year-old 2.13.1 branch, which is why the build is failing. If you rebase onto master, I think the build should pass.

@not-an-aardvark
Copy link
Member

Oh actually, the issue is that 2.x is the base branch of this PR for some reason. I think I can update that.

@not-an-aardvark not-an-aardvark changed the base branch from 2.x to master August 5, 2017 08:36
@not-an-aardvark
Copy link
Member

Temporarily closing/reopening this PR so that the CI builds restart.

@gyandeeps gyandeeps merged commit 5ae8458 into eslint:master Aug 5, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants