New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update object-shorthand.md to fix typo. #9066
Conversation
@B3rry, thanks for your PR! By analyzing the history of the files in this pull request, we identified @IanVS, @scriptdaemon and @kaicataldo to be potential reviewers. |
Thanks for the pull request, @B3rry! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Is your eslint fork super old or something? |
With regards to the failing builds? Nope. Forked ~30 mins ago via the site. |
It looks like your commit was created off of the year-old |
Oh actually, the issue is that |
Temporarily closing/reopening this PR so that the CI builds restart. |
What is the purpose of this pull request? (put an "X" next to item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Added a closing quotation mark to the option definition on line 92.
Is there anything you'd like reviewers to focus on?
No.