Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: fix indentation of multiline new.target expressions #9116

Merged
merged 1 commit into from Aug 19, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix

Tell us about your environment

  • ESLint Version: master
  • Node Version: 8.4.0
  • npm Version: 5.3.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

rules:
  indent: error

What did you do? Please include the actual source code causing the issue.

function foo() {
    foo
        .bar;

    new
        .target;
}

What did you expect to happen?

I expected no errors to be reported.

What actually happened? Please include the actual, raw output from ESLint.

<text>
  6:1  error  Expected indentation of 4 spaces but found 8  indent

✖ 1 problem (1 error, 0 warnings)
  1 error, 0 warnings potentially fixable with the `--fix` option.

What changes did you make? (Give an overview)

This updates the indent rule to handle MetaProperty nodes in the same manner as MemberExpression nodes.

Is there anything you'd like reviewers to focus on?

Nothing in particular

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint indent Relates to the `indent` rule rule Relates to ESLint's core rules labels Aug 16, 2017
@eslintbot
Copy link

LGTM

@not-an-aardvark not-an-aardvark merged commit 79062f3 into master Aug 19, 2017
@not-an-aardvark not-an-aardvark deleted the indent-meta-properties branch August 19, 2017 00:50
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 18, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly enhancement This change enhances an existing feature of ESLint indent Relates to the `indent` rule rule Relates to ESLint's core rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants