New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Remove an indirect dependency on jsonify #9444
Conversation
Thanks for the pull request, @realityking! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Thanks for the pull request, @realityking! I took a look to make sure it's ready for merging and found some changes are needed:
Can you please update the pull request to address these? (More information can be found in our pull request guide.) |
Replace json-stable-stringify with json-stable-stringify-without-jsonify. This removes an indirect dependency on jsonify which is unlicensed and not needed in supported environments.
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR. Looks reasonable to me. I just wonder if we should wait for the change to happen in ajv first, before merging this in?
It makes sense to me to wait until |
@ilyavolodin @kaicataldo ajv 5.3.0 has been released. That version removes the dependency on |
@realityking thank for the comment! I created a PR( #9557 ) to upgrade |
Thanks for PR! |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
This removes an indirect dependency on jsonify which is unlicensed and not needed in supported environments. Doesn't yet slim down the installed size as
ajv
has the same dependency. A PR in its repo is also open ajv-validator/ajv#579What changes did you make? (Give an overview)
Replaced
json-stable-stringify
withjson-stable-stringify-without-jsonify
. The modules are identical except for the dependency onjsonify
.Is there anything you'd like reviewers to focus on?
An alternative would be to use nickyout/fast-stable-stringify. I chose not to do so because I'm not sure if eslint can guarantee that there's never a circular dependency.