Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow linting the empty string from stdin (fixes #9515) #9517

Merged
merged 1 commit into from Oct 26, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (fixes #9515)

What changes did you make? (Give an overview)

This fixes an issue where cli would treat an empty-string argument as missing.

Is there anything you'd like reviewers to focus on?

Nothing in particular

This fixes an issue where `cli` would treat an empty-string argument as
missing.
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features labels Oct 25, 2017
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. so quickly! 👍

Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@aladdin-add aladdin-add merged commit b8aa071 into master Oct 26, 2017
@aladdin-add aladdin-add deleted the empty-stdin branch October 26, 2017 13:09
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Apr 25, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Apr 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running eslint in STDIN mode on an empty file prints weirdly formated help text
4 participants