Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release an updated browserify build #9711

Closed
ronami opened this issue Dec 11, 2017 · 5 comments
Closed

release an updated browserify build #9711

ronami opened this issue Dec 11, 2017 · 5 comments
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon

Comments

@ronami
Copy link

ronami commented Dec 11, 2017

Hey,

I'm running eslint in a browser along with monaco-editor (an online ide). I saw there's a browserify build (https://github.com/eslint/eslint/blob/master/package.json#L20), but it's not being released as part of the eslint npm package. I was able to find eslint-browserify (https://www.npmjs.com/package/eslint-browserify) but the last time it was released was 2 years ago.

Can we manually release a new and updated version for eslint-browserify and possibly make a release part of the regular release cycle for future builds? If not, is there anything I can do other than to clone eslint and build it myself?

I will be happy to make a PR to support that, please let me know if any of this makes sense.

Thanks!

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Dec 11, 2017
@not-an-aardvark
Copy link
Member

I don't think eslint-browserify is maintained by the ESLint team; it looks like it was released by someone else.

There was some discussion about supporting browser builds in #8348. The team decided that we don't want to officially support a browser build, but we are willing to accept changes that would make it easier for others to bundle ESLint into a browser build.

@ronami
Copy link
Author

ronami commented Dec 11, 2017

Thanks for the quick response, very appreciated :)

Would you consider releasing a browserify build as part of the eslint npm package? Or possibly as a separate package?

@not-an-aardvark
Copy link
Member

not-an-aardvark commented Dec 11, 2017

As discussed in #8348 (see #8348 (comment) in particular), we don't want to officially support a browser build because it could pose a significant maintenance burden. However, we'll still consider accepting individual code changes that make ESLint easier to run in the browser (when bundled externally), as long as the changes are small and don't have an adverse impact.

In other words, we don't have an officially supported browser build, but you're free to build it yourself when using it as a dependency, and we're willing to make reasonable changes within ESLint if there are significant roadblocks to bundling it externally.

@mysticatea
Copy link
Member

Playground for eslint-plugin-vue might help you. This site is using monaco-editor and eslint together.

@ronami
Copy link
Author

ronami commented Dec 12, 2017

Thank you @mysticatea, I was able to use webpack to bundle eslint and it works nicely :)

@ronami ronami closed this as completed Dec 12, 2017
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jun 11, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

No branches or pull requests

3 participants