-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: support Async iteration (fixes #9891) #9957
Conversation
I had that on the list because there were some problems with the |
I got it. I have missed the issue. |
Thanks for contributing! |
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix
Fixes #9891.
What changes did you make? (Give an overview)
This PR fixes false positive and wrongly autofix about async iteration.
keyword-spacing
rule to check the spacing betweenawait
and(
infor-await-of
loops.no-await-in-loop
rule to not report await expressions onfor-await-of
loops and to reportfor-await-of
loops as same as await expressions.object-shorthand
rule to fix async generators correctly.require-await
rule to handlefor-await-of
loops as same as await expressions.generator-star-spacing
rule for async generators.no-useless-computed-key
rule for async generators.Is there anything you'd like reviewers to focus on?
Are there other rules which need a fix?
I have searched by some node types in rules:
ForOfStatement
,AwaitExpression
,Property
, andMethodDefinition
.@not-an-aardvark I'm not sure about
semi
rule (#9891 (comment)). Thesemi
rule addresses at the end of statements, so it doesn't look to be related to theawait
keyword in the middle of statements.