Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost contributions? #5

Closed
mgol opened this issue Dec 8, 2014 · 2 comments
Closed

Lost contributions? #5

mgol opened this issue Dec 8, 2014 · 2 comments

Comments

@mgol
Copy link

mgol commented Dec 8, 2014

This repository README states: "Espree starts as a fork of Esprima v1.2.2". However, all of history of Esprima up to this point have been conflated into one initial commit. It seems it would be more fair to Esprima contributors to preserve the history.

@nzakas
Copy link
Member

nzakas commented Dec 10, 2014

I'm not sure that preserving the history would do anything but cause confusion, which is why I omitted it. We don't need ask the old commit info because we won't be reverting past what is the initial commit.

All copyright notices have been maintained so everyone is getting proper credit for their work.

@nzakas nzakas closed this as completed Dec 10, 2014
@mgol
Copy link
Author

mgol commented Dec 31, 2014

Copyright notices don't allow to follow changes for specific lines, to see more detailed history etc. which can be useful when tracking reasons for introducing specific code parts. I disagree about the confusion; most forks do keep history from previous projects and for good reasons; it's good to be able to see how the code evolved regardless of it being forked or not.

But well, you've made your choice so I won't be digging further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants