Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up release-please #569

Merged
merged 2 commits into from Apr 20, 2023
Merged

chore: set up release-please #569

merged 2 commits into from Apr 20, 2023

Conversation

btmills
Copy link
Member

@btmills btmills commented Apr 8, 2023

Referencing the checklist from #563, I was still able to complete the first two independently, but one of the TSC members will need to complete the third item:

In setting this up previously on other repositories, some packages already had this setting enabled, so don't be surprised if that's the case.

Fixes #563

To ease review, this differs from https://github.com/eslint/create-config/blob/9fc2de4eb76dd04218b5a4c72a6006563c74f589/.github/workflows/release-please.yml only by the package name:

diff --git ../create-config/.github/workflows/release-please.yml ./.github/workflows/release-please.yml
index 49defac..371943e 100644
--- ../create-config/.github/workflows/release-please.yml
+++ ./.github/workflows/release-please.yml
@@ -14,7 +14,7 @@ jobs:
         id: release
         with:
           release-type: node
-          package-name: '@eslint/create-config'
+          package-name: 'espree'
           pull-request-title-pattern: 'chore: release${component} ${version}'
       - uses: actions/checkout@v3
         if: ${{ steps.release.outputs.release_created }}
@@ -27,14 +27,14 @@ jobs:
         env:
           NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
         if: ${{ steps.release.outputs.release_created }}
-      - run: 'npx @humanwhocodes/tweet "@eslint/create-config ${{ steps.release.outputs.tag_name }} has been released: ${{ steps.release.outputs.html_url }}"'
+      - run: 'npx @humanwhocodes/tweet "espree ${{ steps.release.outputs.tag_name }} has been released: ${{ steps.release.outputs.html_url }}"'
         if: ${{ steps.release.outputs.release_created }}
         env:
           TWITTER_CONSUMER_KEY: ${{ secrets.TWITTER_CONSUMER_KEY }}
           TWITTER_CONSUMER_SECRET: ${{ secrets.TWITTER_CONSUMER_SECRET }}
           TWITTER_ACCESS_TOKEN_KEY: ${{ secrets.TWITTER_ACCESS_TOKEN_KEY }}
           TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}
-      - run: 'npx @humanwhocodes/toot "@eslint/create-config ${{ steps.release.outputs.tag_name }} has been released: ${{ steps.release.outputs.html_url }}"'
+      - run: 'npx @humanwhocodes/toot "espree ${{ steps.release.outputs.tag_name }} has been released: ${{ steps.release.outputs.html_url }}"'
         if: ${{ steps.release.outputs.release_created }}
         env:
           MASTODON_ACCESS_TOKEN: ${{ secrets.MASTODON_ACCESS_TOKEN }}

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've updated the espree package's npm settings to allow for CI tokens to publish.

Just waiting for @mdjermanovic as he is determining when to roll out release-please to more packages.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@linux-foundation-easycla
Copy link

CLA Not Signed

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up release-please
4 participants