feat: Add more type definitions #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
reviewed
Jul 5, 2024
packages/core/src/types.ts
Outdated
Comment on lines
77
to
90
| /** | ||
| * Represents the configuration options for the core linter. | ||
| */ | ||
| export interface LinterOptionsConfig { | ||
| /** | ||
| * Indicates whether or not inline configuration is evaluated. | ||
| */ | ||
| allowInlineConfig?: boolean; | ||
|
|
||
| /** | ||
| * Indicates what to do when an unused disable directive is found. | ||
| */ | ||
| reportUnusedDisableDirectives?: boolean | SeverityName; | ||
| } |
There was a problem hiding this comment.
These are options passed to Linter#verify() (VerifyOptions), not linterOptions in config objects?
There was a problem hiding this comment.
No, this is for the config object. What am I missing?
There was a problem hiding this comment.
In config objects (e.g., in an eslint.config.js file), linterOptions objects have properties:
noInlineConfig: allowed values aretrue,false.reportUnusedDisableDirectives: allowed values are"error","warn","off",2,1,0, and also legacytrue,false. https://github.com/eslint/eslint/blob/7bcda760369c44d0f1131fccaaf1ccfed5af85f1/lib/config/flat-config-schema.js#L287-L305
There was a problem hiding this comment.
Ah, so just missed the numbers. Thanks.
mdjermanovic
reviewed
Jul 8, 2024
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Add some more low-hanging fruit types to
@eslint/coreWhat changes did you make? (Give an overview)
Added several more types to
@eslint/corethat we can make use of now.Related Issues
Is there anything you'd like reviewers to focus on?