This repository has been archived by the owner on Nov 10, 2022. It is now read-only.
Upgrade: update dependencies #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
kaicataldo
force-pushed
the
update-deps
branch
from
c8e29a1
to
bf00acb
Compare
kaicataldo
added
upgrade
aladdin-add
approved these changes
Jan 14, 2020
|
|
||
| module.exports = function(eleventyConfig) { | ||
| addPlugins(eleventyConfig); | ||
| addFilters(eleventyConfig); | ||
| addTransforms(eleventyConfig); | ||
|
|
||
| // Add YAML files as data sources | ||
| eleventyConfig.addDataExtension("yml", contents => yaml.safeLoad(contents)); |
There was a problem hiding this comment.
Suggested change
| eleventyConfig.addDataExtension("yml", contents => yaml.safeLoad(contents)); | |
| eleventyConfig.addDataExtension("yml", yaml.safeLoad); |
There was a problem hiding this comment.
I think we should leave it as-is for now since this is more explicit and a bit safer against either of these APIs changing.
FWIW, the examples are all written this way: https://www.11ty.dev/docs/data-custom/
platinumazure
approved these changes
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eleventy v0.10 adds an API that allows us to add YAML files as a data source! This release is also supposed to improve build speed.