New: Add Ethical Ads #766
New: Add Ethical Ads #766
Conversation
eslint-deprecated
bot
added
the
triage
nzakas
added
accepted
|
Deploy preview for eslint ready! Built with commit 6d13d54 |
There was a problem hiding this comment.
All the pages except the homepage look good.
Is this what you mean by CSS weirdness on the homepage? I tried changing the background to a lighter color just on the homepage, but that looked weird, but making the anchor text lighter (again, just on the homepage) looked okay. Not sure how that would play with ads though.
I'm only seeing the sponsorship fallback on the Netlify deploy, no ads, though the ethicalads script is loading. Just to confirm, is that the expected behavior for the time being?
|
I know this is a WIP - so this might be in the pipeline - but the layout on a few other pages looks a little wonky with the floated ad container as well: Team page: Sponsors page: |
|
@btmills yeah, that's the homepage weirdness I was talking about. I figured out how to fix it. For the others, if you are only seeing the sponsorship fallback, it's possible you have an ad blocker on your browser. The sponsorship fallback will only be shown if the ad doesn't load for some reason. @kaicataldo oops, missed those pages. I'll take a look. |
|
Okay, this should be set now. Thanks for the feedback. |
|
LGTM! I don't there's enough contrast with the ad on the hero of the home page, but that's an existing problem with the current header text as well. Maybe we can find an alternate background image (or scrap the image altogether), but that shouldn't block this. |
|
Okay, I’ll plan on merging on Monday so we can finalize the setup. No sense in having three days of placeholder ads on the site over the weekend. |
This ads Ethical Ads to each page (also removes the banner). The fallback if there is no ad, or if JS is disabled, is to show an ad for sponsoring ESLint.
I have an open question to them about how the ad looks on the homepage as it seems there's some weirdness with the CSS not being caused by us.