Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v45 resolves Node.js path incorrectly #103

Closed
talentlessguy opened this issue Aug 28, 2021 · 2 comments
Closed

v45 resolves Node.js path incorrectly #103

talentlessguy opened this issue Aug 28, 2021 · 2 comments

Comments

@talentlessguy
Copy link
Contributor

In v45, modules that use node.js path, no longer work properly:

import { contentDisposition } from 'https://esm.sh/@tinyhttp/content-disposition@2.0.0'

results in this:

error: Uncaught SyntaxError: The requested module '/v45/path-browserify@1.0.1/deno/path-browserify.js' does not provide an export named 'basename'
    at <anonymous> (https://cdn.esm.sh/v45/@tinyhttp/content-disposition@2.0.0/deno/content-disposition.js:2:66)

trying to import from v44:

import { contentDisposition } from 'https://cdn.esm.sh/v44/@tinyhttp/content-disposition@2.0.0/deno/content-disposition.js'

yields this:

error: Uncaught SyntaxError: The requested module '/v45/path-browserify@1.0.1/deno/path-browserify.js' does not provide an export named 'basename'
    at <anonymous> (https://cdn.esm.sh/v44/@tinyhttp/content-disposition@2.0.0/deno/content-disposition.js:2:66)

here's the source code for a module: https://github.com/tinyhttp/tinyhttp/blob/master/packages/content-disposition/src/index.ts

@ije
Copy link
Member

ije commented Aug 28, 2021

@talentlessguy thanks, i will look into it!

@ije ije closed this as completed in 2810195 Aug 28, 2021
@ije
Copy link
Member

ije commented Aug 29, 2021

@talentless fixed, v46 should work fine, pls clean cache and try again, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants