Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON error in docs #24

Closed
MichaelCurrin opened this issue Feb 18, 2021 · 2 comments
Closed

Fix JSON error in docs #24

MichaelCurrin opened this issue Feb 18, 2021 · 2 comments

Comments

@MichaelCurrin
Copy link

In Bundle Mode of README.md, I see this

{
    "imports": {
        "https://esm.sh/": "https://esm.sh/[react,react-dom,swr]/",
        ...
    }
}

Which causes markdown error validation on ...

You can comment this out, but JSON does not allow comments so you'll still an error.

Solution: Use json5 syntax which supports comments.

```json5
{
    "imports": {
        "https://esm.sh/": "https://esm.sh/[react,react-dom,swr]/",
        // ...
    }
}
```
{
    "imports": {
        "https://esm.sh/": "https://esm.sh/[react,react-dom,swr]/",
        // ...
    }
}
@ije ije closed this as completed in e8dc019 Feb 18, 2021
@ije
Copy link
Member

ije commented Feb 18, 2021

@MichaelCurrin thanks, i just removed the json lang specifier.

@MichaelCurrin
Copy link
Author

Using json5 will keep the syntax highlighting, which is gone now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants