Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to import - postprocessing #297

Closed
Jocke-Wester opened this issue Apr 3, 2022 · 3 comments
Closed

Failed to import - postprocessing #297

Jocke-Wester opened this issue Apr 3, 2022 · 3 comments
Labels
browser Not working in Browser

Comments

@Jocke-Wester
Copy link

Jocke-Wester commented Apr 3, 2022

https://esm.sh/postprocessing

/* esm.sh - error */
throw new Error("[esm.sh] " + "Could not resolve \"three\" (Imported by \"postprocessing\")");
export default null;

Failing module

@Jocke-Wester Jocke-Wester added the browser Not working in Browser label Apr 3, 2022
@Starcounter-Jack
Copy link

Starcounter-Jack commented Apr 3, 2022

It appears to be a bug in esm.sh. It fails on this call (e is not nil) in /server/build.go. It should resolve to something like version "three@0.139.2" as it would satisfy the dependency. If you monkeypath build.go and set version = "0.139.2", the call succeeds in resolving the package.

p, submodule, _, e := getPackageInfo(task.wd, name, version) // version is  ">= 0.107.0 < 0.140.0" name is "three"

@ije
Copy link
Member

ije commented Apr 4, 2022

seems go-semver doesn't support constraint like >= 0.107.0 < 0.140.0, but >= 0.107.0, < 0.140.0 is ok

@ije
Copy link
Member

ije commented Apr 4, 2022

base Masterminds/semver#147, upgrade to v3 can fix this

@ije ije closed this as completed in c6195c1 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser Not working in Browser
Projects
None yet
Development

No branches or pull requests

3 participants