Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externals for bundle mode #498

Closed
goloveychuk opened this issue Jan 14, 2023 · 1 comment · Fixed by #499
Closed

Externals for bundle mode #498

goloveychuk opened this issue Jan 14, 2023 · 1 comment · Fixed by #499

Comments

@goloveychuk
Copy link
Contributor

Thanks for work.
Currently, when bundle mode is on, all deps are bundled.
The change I propose is to use externals arg and don’t bundle listed deps.
If it fits project design, I can provide a PR.
@ije
Copy link
Member

ije commented Jan 14, 2023

hi @goloveychuk i agree this makes a lot of sense and PR welcome, thanks

@goloveychuk goloveychuk mentioned this issue Jan 15, 2023
Merged
@ije ije closed this as completed in #499 Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

respect externals arg in bundle mode goloveychuk/esm.sh
2 participants
@goloveychuk @ije