Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v105: Missing export renderToReadableStream from https://esm.sh/v105/react-dom@18.1.0/es2022/server.js #510

Closed
piscisaureus opened this issue Jan 28, 2023 · 3 comments
Labels
deno Not working in Deno

Comments

@piscisaureus
Copy link

piscisaureus commented Jan 28, 2023

Failing module

https://esm.sh/v105/react-dom@18.1.0/es2022/server.js
The renderToReadableStream export is missing (it is there as a property of the default export though).

> import * as x from "https://esm.sh/v105/react-dom@18.1.0/es2022/server.js"
undefined
> x
Module {
  default: {
    version: "18.1.0",
    renderToString: [Function],
    renderToStaticMarkup: [Function],
    renderToNodeStream: [Function],
    renderToStaticNodeStream: [Function],
    renderToReadableStream: [Function]
  },
  renderToNodeStream: [Function],
  renderToPipeableStream: undefined,
  renderToStaticMarkup: [Function],
  renderToStaticNodeStream: [Function],
  renderToString: [Function],
  version: "18.1.0"
}

Error message

error: Uncaught (in promise) SyntaxError: The requested module 'https://esm.sh/react-dom@18.1.0/server' does not provide an export named 'renderToReadableStream'
    await import(
    ^
    at async https://deno.land/x/aleph@1.0.0-alpha.68/commands/build.ts:35:5
@piscisaureus piscisaureus added the deno Not working in Deno label Jan 28, 2023
@ije
Copy link
Member

ije commented Jan 28, 2023

i looking into it

@ije ije closed this as completed in acc1be1 Jan 28, 2023
@ije
Copy link
Member

ije commented Jan 28, 2023

sorry! this happens because i was trying to fix #483, i will release v106 after testing pass

@ije
Copy link
Member

ije commented Jan 28, 2023

done, v106 is on, and added a test for the export resolving as well

Screenshot 2023-01-29 at 01 56 36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deno Not working in Deno
Projects
None yet
Development

No branches or pull requests

2 participants