Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos on homepage #735

Closed
kevinfiol opened this issue Sep 26, 2023 · 7 comments
Closed

Typos on homepage #735

kevinfiol opened this issue Sep 26, 2023 · 7 comments

Comments

@kevinfiol
Copy link
Contributor

  1. Under Supporting Nodejs/Bun section:

Nodejs(18+) supports http imorting

Should be:

Nodejs(18+) supports http importing

  1. Under Aliasing Dependencies section:

The origin idea was coming from @lucacasonato.

Should be

The original idea came from @lucacasonato.

@ije
Copy link
Member

ije commented Sep 26, 2023

thanks 👍 @kevinfiol would you like to create pr, or i will update later

@kevinfiol
Copy link
Contributor Author

Hi @ije . I can create a PR, but I don't know where that copy lives in the codebase (or if it lives in another repo). If you can point me to that, I can create the PR.

@ije
Copy link
Member

ije commented Sep 26, 2023

Screenshot 2023-09-26 at 22 14 21

why not just click the edit icon in the readme section.

@kevinfiol
Copy link
Contributor Author

kevinfiol commented Sep 26, 2023

Didn't realize the homepage is based off the repo README. I'll open a PR soon.

EDIT: On a second look, the README doesn't contain the first typo, so maybe the homepage just needs to be rebuilt?:
https://github.com/esm-dev/esm.sh/blob/main/README.md?plain=1#L330

I'll still make a PR to fix the second typo.

@kevinfiol
Copy link
Contributor Author

Created #736 which fixes the second typo I mentioned.

@kevinfiol
Copy link
Contributor Author

Thanks for merging #736 , @ije . Just a heads up, it looks like the homepage still needs to be rebuilt. See screenshot:
image

@ije
Copy link
Member

ije commented Sep 28, 2023

thanks, just deployed the changes!

@ije ije closed this as completed Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants