Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: please start making github releases #1547

Closed
kloczek opened this issue Jul 13, 2023 · 6 comments
Closed

RFE: please start making github releases #1547

kloczek opened this issue Jul 13, 2023 · 6 comments

Comments

@kloczek
Copy link

kloczek commented Jul 13, 2023

Is it possible next time on release new version make the github release to have entry on https://github.com/esnet/iperf/releases? 馃

I'm asking because only on make gh release is spread notification about new release to those who have set watch->releases.

More about gh releases is possible to find on
https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository

@swlars
Copy link
Contributor

swlars commented Jul 24, 2023

We're currently not looking into this.

When we previously looked into it, Github releases regenerated the tarballs and the checksum was not guaranteed to match. Since we value verification and authentication, it didn't seem like a good solution.

@kloczek
Copy link
Author

kloczek commented Jul 25, 2023

This RFE has nothing to do with any tar balls.
It is 100% about ONLY spreading info about new version over gh release entry.

@swlars
Copy link
Contributor

swlars commented Sep 7, 2023

Thank you for bringing this to our attention! We're currently looking into this.

@kloczek
Copy link
Author

kloczek commented Sep 7, 2023

Thank you very much 馃憤 馃槃

Few links which I've collected rising this kind of RFEs recently which may help you.

Description about how to add create gh release using gh worflows/actions jbms/sphinx-immaterial#281 (comment)
Other documentation:
https://github.com/marketplace/actions/github-release
https://pgjones.dev/blog/trusted-plublishing-2023/

@userdocs
Copy link

userdocs commented Sep 15, 2023

We're currently not looking into this.

When we previously looked into it, Github releases regenerated the tarballs and the checksum was not guaranteed to match. Since we value verification and authentication, it didn't seem like a good solution.

This sounds like someone was checksumming a file then uploading it as artefact. This is not what you do with releases.

https://github.com/userdocs/iperf3-static/releases/tag/3.15

Just use gh cli

https://cli.github.com/manual/gh_release_upload

There is nothing complicated about releasing iperf3 binaries via github releases.

@swlars
Copy link
Contributor

swlars commented Sep 15, 2023

We already started using github releases, starting with our last release and including the new release today, but thank you for your help. We definitely appreciate the original poster bringing it to our attention.

@swlars swlars closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants