Skip to content
This repository has been archived by the owner on Mar 29, 2018. It is now read-only.

Add option to not generate source map and append sourceMappingURL #164

Closed
AdamFerguson opened this issue Oct 3, 2014 · 8 comments
Closed

Comments

@AdamFerguson
Copy link

Firstly, great project, thanks. I'd like to disable source map generation on the application I'm working on b/c 1) for production builds and 2) the sourceMappingURL that is appended doesn't contain the relative path info of the location the individual files that are being compiled so it ends up resulting in the browser making lots of 404 requests for source map files it can't find.

I looked through writer.js, where source maps are being generated, and doesn't look like the option exists. Am I missing it?

@caridy
Copy link
Contributor

caridy commented Oct 3, 2014

/cc @ericf

@ericf
Copy link
Contributor

ericf commented Oct 3, 2014

Agreed. We should make this configurable. We also ran into an issue when combining modules together from different npm packages into a single Bundle format output — two packages using the same file name rendered the source maps useless since it was missing sourceContents for the dup file names.

It seems like an option to configure the sourceMappingURL, plus the source contents file names is needed. And that could go along with an option to disable outputting source maps entirely.

@eventualbuddha
Copy link
Contributor

I've poured more time than I really had into this recently and need to back off for a week or so. I'd be up for reviewing PRs, though!

@AdamFerguson
Copy link
Author

I'll try and work on a PR for it this weekend. Thanks again for the project!

@eventualbuddha
Copy link
Contributor

Ping @AdamFerguson.

@AdamFerguson
Copy link
Author

@eventualbuddha Pulled it down and started working on it, then got distracted by other things. I'll take another look tonight.

@jdalton
Copy link

jdalton commented Jan 10, 2015

Any updates?

@eventualbuddha
Copy link
Contributor

I'm going to close this partly due to inactivity, but also because I'm working to make http://esperantojs.org/ the module transpiler of choice.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants