Please consider including other licenses mentioned in LICENSE.txt

[musicinmybrain]

What did you do?

Looked at LICENSE.txt.

What did you expect to happen?

All required license text is available.

What actually happened?

The copyright statement and license text for the main BSD-3-Clause license are present, but the file mentions that code is included or derived from libraries with different licenses.

Portions of code from MODP_ASCII - Ascii transformations (upper/lower, etc)
https://github.com/client9/stringencoders
Copyright (c) 2007  Nick Galbreath -- nickg [at] modp [dot] com. All rights reserved.

Checking https://github.com/client9/stringencoders, the MIT license appears to apply. (See my follow-up comment; this code appears to be used under a BSD-3-Clause license.)

Numeric decoder derived from from TCL library
https://opensource.apple.com/source/tcl/tcl-14/tcl/license.terms
 * Copyright (c) 1988-1993 The Regents of the University of California.
 * Copyright (c) 1994 Sun Microsystems, Inc.

Checking https://opensource.apple.com/source/tcl/tcl-14/tcl/license.terms, the TCL license appears to apply.

Both of these licenses require the copyright notice and the license text to be distributed in all copies. Please add the applicable full license text, either in separate files or in LICENSE.txt.

What versions are you using?

• OS: N/A
• Python: N/A
• UltraJSON: 5.5.0

Please include code that reproduces the issue.

Not applicable.

[musicinmybrain]

Actually, it looks like the MODP_ASCII code was included no later than 2012, so it would fall under the BSD-3-Clause license that was in effect at the time rather than the current MIT license. Similar requirements for distribution of license text still apply.

[hugovk]

Thanks for raising this, would you like to create a PR?

[musicinmybrain]

Thanks for raising this, would you like to create a PR?

I got around to it eventually!