Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly should state in Javadoc if Appointment.end is inclusive or exclusive? #168

Open
GoogleCodeExporter opened this issue Oct 28, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link



What version of the product are you using? 
0.9.3.1

Please provide any additional information below.

At least for the purpose of deciding if an appointment straddles a day 
Appointment.date seems to be inclusive.

My preference would be that end date/time is exclusive so that the next 
appointment's start date can be the same as the previous end date without there 
seeming to be an overlap. (so start time be inclusive)

Either way it would be nice if it was documented here.

Also it looks like there is a typo on the @param comment for Appointment.setEnd 
as it mentions the start time.


I'm up for trying to provide a patch if this is a real problem.

Original issue reported on code.google.com by sal...@gmail.com on 2 Oct 2012 at 3:01

@GoogleCodeExporter
Copy link
Author

Hi Sam,

Usually we use other existing products as reference to decide this kind of 
things. Can you check what's the behaviour in Google Calendar, Outlook and iCal?

The idea is that gwt-cal should be as standard (even if it's defacto standard) 
as possible.

I've fixed the typo in the documentation. Thanks

Original comment by ctasada on 2 Oct 2012 at 7:35

@GoogleCodeExporter
Copy link
Author

Hello,

Looks like it is pretty muddy for iCal at least:
http://www.bedework.org/trac/bedework/wiki/Bedework/DevDocs/DtstartEndNotes

I'll try and get time to look at others soon. They seem to be stuck on the 
ambiguity for date (no time) start/end. For date+time start/end I can only see 
exclusive working otherwise you would have to assume some time resolution to 
fake the end time? e.g. a meeting in the last two hours of the day would have 
to be 22:00 to 23:59:59.999 with 1ms resolution.

Cheers

Sam


Original comment by sal...@gmail.com on 2 Oct 2012 at 8:10

@GoogleCodeExporter
Copy link
Author

The Google calendar ics export uses exclusive for date and date+time resolution.

Google calendar API uses exclusive.
https://developers.google.com/google-apps/calendar/v3/reference/events/insert

Outlook seems to skip the issue by have start+duration.
http://msdn.microsoft.com/en-us/library/office/aa211847(v=office.11).aspx

Cheers

Sam

Original comment by sal...@gmail.com on 2 Oct 2012 at 8:45

@GoogleCodeExporter
Copy link
Author

Original comment by Brad.Ryd...@gmail.com on 2 May 2013 at 8:47

  • Changed state: Acknowledged
  • Added labels: Priority-Low, Type-Review
  • Removed labels: Priority-Medium, Type-Defect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant