When there is space in user name he won't get mentions on his name.

[inliquid]

Subj.

[inliquid]

The problem is within getMentions().

1. regexp should be fixed f.i. {2,20} -> {2,40}, see User avatar displays corrupted symbol when username is multibyte #305
2. Function will not work on names which contain spaces because it gets raw $content from the form.

The solution:
$content = htmlentities($content);

[tobyzerner]

I don't understand the issue?

[inliquid]

Okay. Create user with user name '@user User' -> there is space in his name. Try to mention him using '@'. He won't get any notification, until you add this fix:

$content = htmlentities($content);

in getMentions().

[tvb]

@inliquid You mean like so:

public function getMentions($content)
{
    $content = htmlentities($content);

    preg_match_all('/(^|[\s,\.:\]])@([^\s[\]]{2,40})\b/iu', $content, $matches, PREG_SET_ORDER);
    $names = array();
    foreach ($matches as $k => $v) $names[] = str_replace(" ", " ", $v[2]);

    return $names;
}

[inliquid]

@tvb yes, exactly.

[tvb]

Ok, nice. There are still problems with @ mentioning usernames containing spaces and special characters.

The username Dirk Jan is linked in a mention as follows:

http://www.esotalk.org/member/name/DirkJan

Unfortunately the profile is not correctly linked and cannot be loaded.

[inliquid]

I can't reproduce this on my system. There should be member id after name/, like this http://www.esotalk.org/member/name/999-Dirk-Jan. Maybe it wasn't space (ascii 0x20) when entering name?

[inliquid]

Look at this oneas well #306

[tvb]

Sec. I'll make a screenshot.

[tvb]

Screenshot:

[tvb]

This one also breaks:

note that user @Mike and @Mandy are correctly linked to there profile and working.

[inliquid]

I was wrong - it's a search string, so no need for member Id here.
However I do not have such problem, my site works fine even with unicode (with some fix):

[tvb]

What are those fixes? And can you try to reproduce it with username Martin & Tina just to be sure?

[inliquid]

I'd fixed slug function, I think this fix is now included in development branch, plus these fixes of #306, I have written in description there. Just a minute will try this user name.

[tvb]

I am running dev version so the fix should be included already..

[tvb]

And added the{2,20} to {2,40} fix already

[inliquid]

I have developed a simple filter for user name based on regexp, so anything different from alphanumeric plus spaces '-' and '' is transformed to ''. Mentions with '&' will be broken. I have also opened a ticket few months ago. Will try to find.

[inliquid]

Look at #311

[tvb]

I don't want to block characters from username, it should work in all cases.

[inliquid]

It will not work with existing mechanism with any special character. (And I'm not sure it's possible - you have to somehow understand that here is the end of nickname, righ now it's   sequence that will not be transformed, but real space or puctuation breaks the line.

[tvb]

I understand it is somewhat impossible with the current implementation. Hmmm