Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API as a preference #69

Closed
Rudloff opened this issue May 27, 2018 · 4 comments
Closed

Add API as a preference #69

Rudloff opened this issue May 27, 2018 · 4 comments

Comments

@Rudloff
Copy link

Rudloff commented May 27, 2018

Hello,

Instead of adding the API key before building the app, would it be possible to add an option to enter an API key in the app preferences. This would allow changing the key without rebuilding the app.

@esoxjem
Copy link
Owner

esoxjem commented May 29, 2018

Hey @Rudloff, you need to build the code at least once anyway.

@Rudloff Rudloff mentioned this issue May 29, 2018
@Rudloff
Copy link
Author

Rudloff commented May 29, 2018

Yes, but not every body knows how to build an app.

I assumed you were not distributing APKs with your API key because the TMDB API is rate-limited. This would allow distributing key-less APK and let people enter the key manually.

@rijogeorge7
Copy link
Contributor

I think if we do so ,we can distribute this app and when user open the app for the first time we can ask the user to enter an api key to proceed

@esoxjem
Copy link
Owner

esoxjem commented Jul 23, 2018

I need to have a bit more features in before I consider this and distribute on F-Droid. Thanks for the suggestions @Rudloff @rijogeorge7

@esoxjem esoxjem closed this as completed Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants