refactor(NVS): refactor setString

esp-admin · Jun 21, 2024 · 1f789a4 · 1f789a4
1 parent 1de636f
commit 1f789a4
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/src/NVS.cpp b/src/NVS.cpp
@@ -78,13 +78,19 @@ namespace ESPAdmin
      */
     void NVS::setString(const char *key, const char *value) const
     {
-        esp_err_t err = nvs_set_str(_handler, key, value == nullptr ? "" : value);
+        const char *valueToSet = (value == nullptr) ? "" : value;
 
-        nvs_commit(_handler);
+        esp_err_t err = nvs_set_str(_handler, key, valueToSet);
+        if (err != ESP_OK)
+        {
+            _logger.warn("failed to write value of %s", key);
+            return;
+        }
 
+        err = nvs_commit(_handler);
         if (err != ESP_OK)
         {
-            _logger.warn("failed to write string %s", key);
+            _logger.warn("failed to commit value of %s", key);
         }
     }