Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allowed clippy lints from CI checks and resolve resulting errors #1161

Closed
jessebraham opened this issue Feb 12, 2024 · 0 comments · Fixed by #1167
Closed

Remove allowed clippy lints from CI checks and resolve resulting errors #1161

jessebraham opened this issue Feb 12, 2024 · 0 comments · Fixed by #1167
Labels
CI Continuous integration/deployment help wanted Extra attention is needed

Comments

@jessebraham
Copy link
Member

In #1134 I "fixed" the clippy checks in CI, however we are still allowing a number of lints which I just did not feel like resolving at that point in time (I had already fixed a lot of them 😅).

We should decide which (if any) lint rules we should allow, and then add a [clippy.lints] section to our cargo manifest to be explicit about these (if required). We must then also update the CI workflow to remove the currently allowed lints, and fix any resulting errors.

@jessebraham jessebraham added help wanted Extra attention is needed CI Continuous integration/deployment labels Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration/deployment help wanted Extra attention is needed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant