Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV mismatch #131

Closed
har7an opened this issue Aug 3, 2022 · 0 comments · Fixed by #132
Closed

MSRV mismatch #131

har7an opened this issue Aug 3, 2022 · 0 comments · Fixed by #132

Comments

@har7an
Copy link
Contributor

har7an commented Aug 3, 2022

Hello,

the README states that the MSRV is 1.59.0. However, when compiling for esp32 from main with the 1.61.0 toolchain, I get the following error:

   Compiling esp-hal-procmacros v0.1.0 (/var/home/ahartmann/repos/mt/playground/esp-hal/esp-hal-procmacros)
error[E0658]: use of unstable library feature 'bool_to_option'
   --> /var/home/ahartmann/repos/mt/playground/esp-hal/esp-hal-procmacros/src/lib.rs:228:35
    |
228 |         (f.sig.inputs.len() == 1).then_some(Ident::new("context", proc_macro2::Span::call_site()));
    |                                   ^^^^^^^^^
    |
    = note: see issue #80967 <https://github.com/rust-lang/rust/issues/80967> for more information
    = help: add `#![feature(bool_to_option)]` to the crate attributes to enable

For more information about this error, try `rustc --explain E0658`.
error: could not compile `esp-hal-procmacros` due to previous error

And indeed this language feature was added as part of this PR and landed in Rust 1.62.0. This bumps the MSRV to 1.62.0.

Maybe it would be a good idea to add some github action that compiles the code against the MSRV mentioned in the Readme so it doesn't break along the way, or at least gets recognized automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant