Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smart_leds_adapter should take a rate instead of assuming rmt to be configured in a special way #74

Closed
bjoernQ opened this issue Jun 8, 2022 · 3 comments
Closed

smart_leds_adapter should take a rate instead of assuming rmt to be configured in a special way #74

bjoernQ opened this issue Jun 8, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@bjoernQ
Copy link
Contributor

bjoernQ commented Jun 8, 2022

Currently smart_leds_adapter assumes the pulse_control is configured to 40Mhz - easiest solution would be to take a rate which the user should have configure for the pulse_control
@jessebraham jessebraham added this to the v0.2.0 milestone Aug 22, 2022
@jessebraham jessebraham removed this from the v0.2.0 milestone Sep 13, 2022
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Nov 17, 2022

Not sure how relevant this is anymore since ideally the SmartLeds stuff should get moved into its own crate some day

see #252

@jessebraham jessebraham changed the title smart_leds_adapter should take a rate instead of assuming pulse_control to be configured in a special way smart_leds_adapter should take a rate instead of assuming rmt to be configured in a special way Aug 9, 2023
@jessebraham jessebraham added the good first issue Good for newcomers label Aug 14, 2023
@bjoernQ
Copy link
Contributor Author

bjoernQ commented Aug 30, 2023

Probably the easiest would be to just explicitly state in the API docs of smart_leds_adapter that the user needs to specify exactly 80MHz and we can close this

@jessebraham jessebraham mentioned this issue Oct 17, 2023
Closed
@jessebraham
Copy link
Member

I guess with #1154 merged this is no longer relevant, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
esp-rs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessebraham @bjoernQ