Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2CDriver does not implement i2c::Transactional #197

Open
JohnTheCoolingFan opened this issue Dec 25, 2022 · 4 comments
Open

I2CDriver does not implement i2c::Transactional #197

JohnTheCoolingFan opened this issue Dec 25, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@JohnTheCoolingFan
Copy link

Some libraries (for example, pn532) rely on implementation of i2c::Transactional from embedded_hal.

@MabezDev
Copy link
Member

MabezDev commented Jan 3, 2023

Transactions should build on top of the existing read/write implementations, so this should be straight forward to implement.

@MabezDev MabezDev added enhancement New feature or request help wanted Extra attention is needed labels Jan 3, 2023
@Vollbrecht
Copy link
Collaborator

related changes in embedded-hal upstream: 8b984d299a1926350d52fa2645a84190ef025dbe

@Vollbrecht
Copy link
Collaborator

Vollbrecht commented Apr 1, 2023

@MabezDev i can try to implement the trait, though it backs the question if we should actively implement e-hal_02 traits for backwards comparability (where there were not already implemented before), or should wait for the drivers themself to implement the current traits. How do you guys handle this in no_std?

@MabezDev
Copy link
Member

How do you guys handle this in no_std?

We implement both where possible, but I don't think its a super strict rule. For example, we don't implement any of the transaction stuff for i2c in the no_std hals currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

3 participants