Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2S reconfiguration support #334

Open
bbutkovic opened this issue Nov 9, 2023 · 2 comments · May be fixed by #335
Open

I2S reconfiguration support #334

bbutkovic opened this issue Nov 9, 2023 · 2 comments · May be fixed by #335

Comments

@bbutkovic
Copy link

I'm working on a project and I'd like to be able to reconfigure the I2S channels on-the-fly.

The IDF already has support for that so it would be great if we could also do it here.

I'm willing to work on this, in fact I started already, going to post a WIP PR.

@bbutkovic bbutkovic linked a pull request Nov 9, 2023 that will close this issue
@ivmarkov
Copy link
Collaborator

Can you describe a bit your specific use case, and in particular - why dropping and re-creating the driver would not work for your case?

@bbutkovic
Copy link
Author

I'm writing a sort-of wrapper around the I2S driver that I may or may not publish later as a crate. I hold the driver within my struct wrapper, meaning when I want to drop and re-create the driver I have to also keep ties to the peripherals or pass them into the function that calls for re-configuration. This is all doable but by using the API above it would make it a little bit cleaner and easier to reason about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

2 participants